Add a Django Model MixIn #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces this syntax:
```
from django_cte import CTEManager
class Order(Model):
objects = CTEManager()
```
with this:
```
from django_cte import CTEModelMixIn
class Order(Model, CTEModelMixIn):
```
entirely, optionally (that is the earlier syntax works too). This is simply a more canonical (IMHO) Django way of offering the same service (and has extensibility advantages - as in should the package ever need any more model enhancements, the MixIn is there to take them)
millerdev
reviewed
Jul 12, 2023
|
If there was only one way to do it, I'd still vote for a MixIn rather than overriding an attribute, as it strikes me as both more Django and is more extensible. Either way, it's a small value add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces this syntax:
with this:
entirely, optionally (that is the earlier syntax works too). This is simply a more canonical (IMHO) Django way of offering the same service (and has extensibility advantages - as in should the package ever need any more model enhancements, the MixIn is there to take them)